Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new node command to fuels CLI #2376

Merged
merged 6 commits into from
May 24, 2024
Merged

feat: add new node command to fuels CLI #2376

merged 6 commits into from
May 24, 2024

Conversation

Dhaiwat10
Copy link
Member

Closes #2355

@Dhaiwat10 Dhaiwat10 added the feat Issue is a feature label May 23, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this May 23, 2024
@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review May 23, 2024 00:10
petertonysmith94
petertonysmith94 reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Probably worth adding the command to the README.md.

packages/fuels/src/cli/commands/node/index.ts Outdated Show resolved Hide resolved
danielbate
danielbate previously approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

packages/fuels/src/cli.ts Show resolved Hide resolved
@Dhaiwat10
Copy link
Member Author

@petertonysmith94 added to readme: 643f9c2

maschad
maschad approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this!

@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) May 23, 2024 17:11
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.79%(+0.04%) 70.77%(+0.09%) 76.99%(+0.13%) 79.89%(+0.05%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ packages/fuels/src/cli/commands/node/index.ts 87.5%
(+87.5%)		 100%
(+100%)		 100%
(+100%)		 88.46%
(+88.46%)

@Dhaiwat10 Dhaiwat10 merged commit ba0f3d0 into master May 24, 2024
18 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/fuels-node-command branch May 24, 2024 08:41
@fuel-service-user fuel-service-user mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding new node command to fuels CLI
6 participants
@Dhaiwat10 @danielbate @maschad @petertonysmith94 @nedsalk @Torres-ssf