Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: implement pagination for
Account
methods #2408base: master
Are you sure you want to change the base?
feat!: implement pagination for
Account
methods #2408Changes from all commits
defe281
718055b
21364ce
638481a
f0f3411
57e2f0a
abf3b71
b6b34ca
f718939
4850e28
94636b5
3847ec2
5368078
e4ae168
4c8c261
869d410
9b3c91d
9a3840c
1e79dde
2dddd38
c159171
44b5ef0
c66ba2c
3dce4b4
7be96e5
e1bf612
c8ad228
aa0f6c7
830fa46
b2238b0
7837d8e
3da88b2
e45e3ef
8caf981
b905970
6a947b4
435c7c8
8d849a5
1c88a6b
0088738
13bebc7
9928ce6
999d357
7fec40b
14d3a26
dd5308b
d0e8b58
c485bc5
0f705a4
95a1bcd
b7f9393
8a4cf16
b67eac3
c465c10
0776e6f
d5c8429
e294b55
90aa82c
1ee4bb8
5f76ffe
dbbf85b
2926c83
6f35d20
b1d0e5e
b64cb79
2527d17
649a906
c696338
9d13959
c1cb5e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this pattern throughout the pagination test suite but I'm not sure what the benefit of these assertions are, given that an initialized object will always be defined.
In the context of them being passed to
provider.getCoins()
I think an assertion that thepageInfo
returned is the logical consequence of a particularpaginationArgs
suffices, but otherwise just asserting that aGqlPageInfo
object orCursorPaginationArgs
is defined doesn't offer any value imo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maschad The tests within the
doc-snippets
dir exist to be used as code snippets only. We should not rely on those tests to validate our implementationThe changes made within this PR are being tested here and here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that, I elaborated a more in my final review comment , but I am suggesting that these snippet regions be incorporated into a larger test such as the ones you linked, rather than having an individual test just for the initialization of an object.