chore: remove some choices from create-fuels CLI
#2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is published in NPM with version 0.0.0-pr-2444-20240618181855 |
|
Is there an issue we can link this PR to? |
|
@arboleya I don't think there is one. This just started off as a quick draft at the offsite without an issue. I will create one. |
….com/FuelLabs/fuels-ts into dp/create-fuels-remove-extra-choices
Dhaiwat10
requested review from
digorithm,
arboleya and
Torres-ssf
as code owners
|
@Dhaiwat10 are these not the issues you seek? |
nedsalk
reviewed
Jun 13, 2024
nedsalk
reviewed
Jun 13, 2024
|
@Dhaiwat10 As @petertonysmith94 said here, I think these are the original issues:
Maybe you can close #2508 in favor of these or vice versa. Or close them all with the PR. |
nedsalk
approved these changes
Jun 19, 2024
arboleya
reviewed
Jun 19, 2024
maschad
reviewed
Jun 19, 2024
maschad
approved these changes
Jun 19, 2024
|
Coverage Report:
Changed Files:
|
nedsalk
pushed a commit
that referenced
this pull request
Jun 27, 2024
* remove some choices * enable pr release * delete unnecessary files, make npm default * fix merge conflicts * remove old exports * fix lint errors * add changeset * fix changeset * fix test * fix lint errors * fix lint error * remove outdated test * fix failing test, remove unnecessary awaits * remove asyncs * remove from docs * remove env vars, fix up tests * disable pr release --------- Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk> Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes two choices from the
create-fuelsCLI which we now deem unnecessary.1. Package Manager
The CLI will just use
npmas the default from now on. I tried to add some logic that would detect the package manager used by the user to call the command but have not find a reliable solution yet. Follow up #2552.Users can still explicitly specify if they want to use a specific package manager by flags like
--bun,--pnpm2. Programs to include
From now on we will just give our users all three programs included in the template, instead of giving them a choice when the CLI is run. If they want only one or two, they can easily delete the rest themselves.
create-fuelsCLI #2508