-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add support for latest node versions #2539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maschad You must add the new node version to the CI matrix.
@danielbate Right?
fuels-ts/.github/workflows/test.yaml
Lines 20 to 26 in 93f1407
matrix: | |
env: | |
[ | |
{ name: node, version: 18.18.2 }, | |
{ name: node, version: 20 }, | |
{ name: browser }, | |
] |
Another question is: should we still support v18?
That looks about right, good catch!
I would say so given it's still maintained according to the current release working group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Thanks for pointing that out, I've done that in |
I believe the only way to unfreeze it is to do what we discussed since it's still a required workflow. I would do that after this is merged though to prevent interference with other open PRs. |
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Coverage Report:
Changed Files:Coverage values did not change👌. |
Closes #2221
This also upgrades
pnpm