Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add support for latest node versions #2539

Merged
merged 30 commits into from
Jun 25, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Jun 17, 2024

Closes #2221

This also upgrades pnpm

Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maschad You must add the new node version to the CI matrix.

@danielbate Right?

matrix:
env:
[
{ name: node, version: 18.18.2 },
{ name: node, version: 20 },
{ name: browser },
]

Another question is: should we still support v18?

@maschad
Copy link
Member Author

maschad commented Jun 17, 2024

@maschad You must add the new node version to the CI matrix.

@danielbate Right?

That looks about right, good catch!

Another question is: should we still support v18?

I would say so given it's still maintained according to the current release working group

@maschad maschad changed the title build: support latest node versions build: add support for latest node versions Jun 17, 2024
@maschad maschad requested a review from arboleya June 18, 2024 03:26
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few places (here, here etc.) where we default to v20, lets get those updated too?

@petertonysmith94
Copy link
Contributor

petertonysmith94 commented Jun 18, 2024

There's a few places (here, here etc.) where we default to v20, lets get those updated too?

I'd suggest updating to v20.14.0 as it's the LTS version of Node.

.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
@maschad
Copy link
Member Author

maschad commented Jun 18, 2024

There's a few places (here, here etc.) where we default to v20, lets get those updated too?

Thanks for pointing that out, I've done that in e54dda8 (#2539) , unfortunately there isn't a clear formulaic way to ensure I've updated it everywhere, but I've looked where I thought may be relevant 😅

arboleya
arboleya previously approved these changes Jun 22, 2024
@maschad
Copy link
Member Author

maschad commented Jun 22, 2024

One workflow seems to be stuck.

I believe the only way to unfreeze it is to do what we discussed since it's still a required workflow. I would do that after this is merged though to prevent interference with other open PRs.

nedsalk
nedsalk previously approved these changes Jun 24, 2024
@maschad maschad dismissed stale reviews from nedsalk and arboleya via 21026a3 June 24, 2024 14:06
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
@maschad
Copy link
Member Author

maschad commented Jun 24, 2024

@nedsalk do you have any ideas why this might be failing to fetch coverage here

Seems to be happening on quite a few PRs, raised an issue #2612

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.38%(+0%) 71.29%(+0%) 76.44%(+0%) 79.45%(+0%)
Changed Files:

Coverage values did not change👌.

@maschad maschad enabled auto-merge (squash) June 25, 2024 13:08
@arboleya arboleya disabled auto-merge June 25, 2024 15:02
@maschad maschad merged commit a9ece17 into master Jun 25, 2024
21 checks passed
@maschad maschad deleted the mc/chore/support-latest-node branch June 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Node LTS and other ranges
6 participants