Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add UNKNOWN error code #2562

Merged
merged 22 commits into from
Jun 25, 2024
Merged

chore: add UNKNOWN error code #2562

merged 22 commits into from
Jun 25, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Jun 20, 2024

This is the only specific use case I can currently see in the codebase. I'm not sure if any other error handling use cases apply at the moment @Torres-ssf

@maschad maschad self-assigned this Jun 20, 2024
@github-actions github-actions bot added the chore Issue is a chore label Jun 20, 2024
@maschad maschad changed the title chore: added UNKNOWN error code chore: add UNKNOWN error code Jun 20, 2024
danielbate
danielbate previously approved these changes Jun 20, 2024
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure about the issue #2470.

Potentially it's a duplicate of #2521?

packages/account/src/providers/utils/extract-tx-error.ts Outdated Show resolved Hide resolved
apps/docs/src/guide/errors/error-codes.md Outdated Show resolved Hide resolved
apps/docs/src/guide/errors/error-codes.md Outdated Show resolved Hide resolved
packages/errors/src/error-codes.ts Outdated Show resolved Hide resolved
@arboleya
Copy link
Member

I'm not entirely sure about the issue #2470.
Potentially it's a duplicate of #2521?

@petertonysmith94 Almost, but not 100%.

The latter also requires the addition of the rawError property, which should be required for all FuelErrors.

maschad and others added 4 commits June 20, 2024 10:35
@maschad maschad requested a review from arboleya June 21, 2024 20:45
arboleya
arboleya previously approved these changes Jun 22, 2024
@maschad maschad requested a review from Torres-ssf June 22, 2024 14:56
Torres-ssf
Torres-ssf previously approved these changes Jun 24, 2024
@maschad maschad enabled auto-merge (squash) June 24, 2024 23:10
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.38%(-0.66%) 71.29%(-0.74%) 76.44%(-0.41%) 79.45%(-0.64%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ apps/create-fuels-counter-guide/src/pages/predicate.tsx 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)
🔴 packages/errors/src/test-utils/expect-to-throw-fuel-error.ts 95.83%
(+0.83%)
94.44%
(+1.59%)
100%
(+0%)
95.83%
(+0.83%)

@maschad maschad merged commit eec0806 into master Jun 25, 2024
20 checks passed
@maschad maschad deleted the mc/chore/unknown-error-code branch June 25, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UNKNOWN error code and rawError property to FuelError Create Unknown Error Code
5 participants