-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add preview link for docs changes #2578
chore: add preview link for docs changes #2578
Conversation
Before merging the PR, someone must grant some permissions to the repository related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also post the preview link as a comment on the PR.
Here's one example of how coverage report does it:
fuels-ts/.github/workflows/test.yaml
Lines 154 to 162 in e2259ed
- name: Report Coverage uses: thollander/actions-comment-pull-request@v2 if: ${{ steps.findPr.outputs.number }} with: filePath: coverage/report/coverage-diff.txt pr_number: ${{ (steps.findPr.outputs.number) }} comment_tag: diff mode: recreate create_if_not_exists: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this override our existing GitHub pages deployment?
https://fuellabs.github.io/fuels-ts/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, couple comments
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Co-authored-by: Daniel Bate <djbate23@gmail.com>
Probably yes, but we can see some way to create pages based on Get a look at this. |
It looks like currently GH pages doesn't support preview deployment and from the discussion, it doesn't look remotely close. I have hesitations about deploying to our primary GH page, and potentially deploying to Vercel is a better approach. What are other peoples thoughts? cc: @FuelLabs/sdk-ts |
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
I agree with you. Maybe it may be interesting to try something with Vercel (By the way, vercel already has a |
@petertonysmith94 Agreed. We should use a different strategy here. Vercel seems to be a good suggestion. |
@Torres-ssf, considering that we are likely already planning a different strategy here, I think this PR is now beyond their scope. Should this PR be closed? |
Summary
This PR provides a preview link for pull requests that change the docs. That offers several benefits as:
GitHub Pages
Breaking Changes
This actions needs at least: