Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: send multiples transactions to the network #2672

Closed
wants to merge 9 commits into from
Closed

feat!: send multiples transactions to the network #2672

wants to merge 9 commits into from

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Jul 1, 2024

@github-actions github-actions bot added the feat Issue is a feature label Jul 1, 2024
@petertonysmith94 petertonysmith94 added this to the 0.x post-launch milestone Jul 1, 2024
@mvares mvares changed the title feat: send multiples transactions to the network feat!: send multiples transactions to the network Jul 1, 2024
mvares
mvares commented Jul 1, 2024
View reviewed changes
packages/account/src/account.ts
}
}

// TODO: decide whether we should return an array of successful transactions or non
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Torres-ssf, if a X was processed, but X + 1 wasn't processed, is it possible to revert X?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvares No, we cannot revert a TX that was already processed.

For this one needs to return an array of successful/reverted transactions

@maschad
Copy link
Member

maschad commented Jul 1, 2024

Thanks for taking this on @mvares , I think there needs to be more discussion around the issue first before beginning any work on it as it's quite complex.

@maschad maschad added the blocked Something is blocking development on this issue label Jul 1, 2024
@mvares mvares closed this Jul 6, 2024
@mvares mvares deleted the mv/add-multiple-tx-method branch July 6, 2024 11:22
@mvares mvares restored the mv/add-multiple-tx-method branch July 6, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf left review comments

@digorithm digorithm Awaiting requested review from digorithm digorithm will be requested when the pull request is marked ready for review digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya will be requested when the pull request is marked ready for review arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 will be requested when the pull request is marked ready for review Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate will be requested when the pull request is marked ready for review danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk will be requested when the pull request is marked ready for review nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 will be requested when the pull request is marked ready for review petertonysmith94 is a code owner

@maschad maschad Awaiting requested review from maschad maschad will be requested when the pull request is marked ready for review maschad is a code owner

Assignees

@mvares mvares

Labels
blocked Something is blocking development on this issue feat Issue is a feature
Projects
None yet
Milestone
0.x post-launch
Development

Successfully merging this pull request may close these issues.

Implement Transaction Queue Support
4 participants
@mvares @maschad @Torres-ssf @petertonysmith94