Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove awaitExecution functionality #2820

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Jul 23, 2024

Release notes

In this release, we:

  • Remove the awaitExecution flag and its associated functionality

Summary

This PR removes the awaitExecution flag and its functionality. After the changes introduced in #2597 and #2692 the SDK no longer uses this functionality internally. Although users could still manually submit transactions using the awaitExecution flag after #2597 and #2692, this is no longer supported.

Breaking Changes

It is no longer possible to submit transactions using the awaitExecution flag and wait for the transaction to be processed at submission:

// before
await account.sendTransaction(transactionRequest, { awaitExecution: true }); 
// after
const submit = await account.sendTransaction(transactionRequest);

const response = await submit.waitForResult();

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@Torres-ssf Torres-ssf added chore Issue is a chore p1 Medium priority labels Jul 23, 2024
@Torres-ssf Torres-ssf self-assigned this Jul 23, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.39%(+0.03%) 71.53%(-0.12%) 77.32%(+0.02%) 79.52%(+0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 82.31%
(+1.16%)
65.07%
(+1.14%)
82.35%
(+0.54%)
82%
(+1.15%)
🔴 packages/account/src/providers/provider.ts 67.31%
(-1.53%)
62.28%
(-1.54%)
73.49%
(-0.31%)
67.3%
(-1.49%)
🔴 packages/account/src/test-utils/launchNode.ts 98.27%
(+0.01%)
85.24%
(+0.5%)
100%
(+0%)
98.36%
(+0.02%)
🔴 packages/contract/src/contract-factory.ts 58.33%
(-0.29%)
46.42%
(+0.27%)
54.54%
(+0%)
58.33%
(-0.29%)
🔴 packages/contract/src/util.ts 93.75%
(+0.42%)
0%
(+0%)
66.66%
(+0%)
88.88%
(+0.65%)
🔴 packages/create-fuels/src/cli.ts 85.5%
(+0.21%)
37.5%
(-2.5%)
100%
(+0%)
85.5%
(+0.21%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove awaitExecution flag
4 participants