-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: panic receipts have doc links #456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d1349a
to
1ce2e30
Compare
Total Coverage: 89.56% Coverage Report
|
1ce2e30
to
4acd31b
Compare
Total Coverage: 89.59% Coverage Report
|
4acd31b
to
7bb2915
Compare
a9516f3
to
5ebcd21
Compare
Total Coverage: 89.59% Coverage Report
|
LuizAsFight
requested changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good...
could you fix lint warnings?
5ebcd21
to
09bafa2
Compare
luizstacio
approved these changes
Aug 22, 2022
Total Coverage: 89.66% Coverage Report
|
Total Coverage: 89.66% Coverage Report
|
@LuizAsFight can you take another look? I removed all the committed lining issues. thx!!! |
LuizAsFight
approved these changes
Aug 23, 2022
Total Coverage: 89.71% Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#TLDR:
Still figuring out why the panic receipt errors are
u64
, notu8
- It's most likely an issue with the client. But in the mean time, the result has a failure reason and this PR uses this value to provide feedback to the user.New output