chore: now bn accepts null
#523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success520 tests passing in 46 suites. Report generated by 🧪jest coverage report action from cdbafcd |
camsjams
approved these changes
Sep 27, 2022
luizstacio
reviewed
Sep 27, 2022
| @@ -251,7 +251,7 @@ export class BN extends BnJs implements BNInputOverrides, BNHiddenTypes, BNHelpe | |||
| } | |||
|
|
|||
| // functional shortcut to create BN | |||
| export const bn = (value?: BNInput, base?: number | 'hex', endian?: BnJs.Endianness) => | |||
| export const bn = (value?: BNInput | null, base?: number | 'hex', endian?: BnJs.Endianness) => | |||
There was a problem hiding this comment.
Should we change the type BNInput?
There was a problem hiding this comment.
I think no. a lot of helper methods use BNInput but shouldn't accept a null/undefined as values.
for example:
bn(10).mul() should not work. It's needed to explicitly say the value I want to multiply to mul method, which has BNInput as input typing
luizstacio
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.