Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove export of versions package on fuels #650

Merged
merged 3 commits into from
Dec 9, 2022
Merged

fix: remove export of versions package on fuels #650

merged 3 commits into from
Dec 9, 2022

Conversation

luizstacio
Copy link
Member

closes: #649

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
91.13% (-0% 🔻)
 3834/4207
🟡 Branches 74.57% 745/999
🟢 Functions 88.12% 749/850
🟢 Lines
91.17% (-0% 🔻)
 3677/4033

Test suite run success

597 tests passing in 63 suites.

Report generated by 🧪jest coverage report action from 68c6079

@luizstacio luizstacio enabled auto-merge (squash) December 9, 2022 08:47
Dhaiwat10
Dhaiwat10 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@Dhaiwat10 Dhaiwat10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Why was the versions package being exported in the first place though? Weird

@arboleya
Copy link
Member

arboleya commented Dec 9, 2022 •
edited

LGTM! Why was the versions package being exported in the first place though? Weird

@Dhaiwat10 I did it on auto-pilot. 😓

@luizstacio luizstacio merged commit 790209d into master Dec 9, 2022
@luizstacio luizstacio deleted the ls/fix/649 branch December 9, 2022 12:29
@arboleya arboleya mentioned this pull request Dec 9, 2022
Closed
@github-actions github-actions bot mentioned this pull request Dec 9, 2022
Merged
@luizstacio luizstacio self-assigned this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@camsjams camsjams Awaiting requested review from camsjams

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight

Assignees

@luizstacio luizstacio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fuels package issue on browser environment
3 participants
@luizstacio @arboleya @Dhaiwat10