-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adlerjohn - looks great! great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waaaait a second. Do we want to publish to NPM every push to master
, or every tagged release?
I suggest publish npm packages with every push to master (with master being stable code) - my perspective |
What would be the version number/string that it would be published under, if it's not for tagged releases? |
@adlerjohn - as you mentioned, publishing npm packages every release is a smart move, but would be good to publish those for master as well perhaps for release v1.2.0 (just an example) something like for master branch "1.2.0-beta" for a package and then for final release "1.2.0" (these names could change of course) again this it totally up to the dev team - whatever they prefer. |
Here's what I had planned: We have two release channels:
This PR sets up the "master releases" part and leaves regular releases for later. They are more complicated and I think there should be an effort involving all of our repos for that so we don't reinvent the wheel on every repo. |
I've created this issue as a follow-up: #85 |
Not going to block this PR, but can you document your above comment in the CI config file as a comment @AlicanC? |
This PR adds a release workflow that publishes packages on push to
master
.Resovles #38