Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: configure spell-check #987

Merged
merged 9 commits into from
Dec 13, 2023
Merged

docs: configure spell-check #987

merged 9 commits into from
Dec 13, 2023

Conversation

sarahschwartz
Copy link
Contributor

@sarahschwartz sarahschwartz commented Nov 22, 2023

This PR configures the spell-check added to the docs workflow in the github-actions repo: FuelLabs/github-actions#23

The files checked are configured in .spellcheck.yml. This is also where you can configure what types of elements are ignored.

Right now it ignores:

  • All code blocks that have a language (and will check code blocks that do not have a language)
  • Anything in between backticks
  • Words in spell-check-custom-words.txt (case sensitive, only exact match)
  • Numbers, even if they are attached to a word
  • Links in markdown link format

Handling errors:

If the test fails:

  • look up the word in the question to verify it is a real word and is correctly spelled
  • If it is a file name or is code, use backticks to ignore the word.
  • If it is a real word that is spelled correctly, or an acronym that is either common or is defined already, add it to spell-check-custom-words.txt.
  • If needed, rewrite the sentence. Ex: DON'T use "locking" and add "ing" to the custom words list. Instead, rewrite the sentence as "locking with the lock method".
  • If it otherwise should be ignored, you can configure the pipeline in .spellcheck.yml.

Copy link
Contributor

github-actions bot commented Nov 22, 2023

Coverage report for ./packages/app

St.
Category Percentage Covered / Total
🟡 Statements 66.58% 3381/5078
🔴 Branches 43.93% 619/1409
🔴 Functions 50.21% 713/1420
🟡 Lines 67.2% 3260/4851

Test suite run success

241 tests passing in 73 suites.

Report generated by 🧪jest coverage report action from 297230e

@sarahschwartz sarahschwartz changed the title fix: spelling docs: configure spell-check Dec 7, 2023
sarahschwartz added a commit to FuelLabs/github-actions that referenced this pull request Dec 7, 2023
This PR adds a spell-check to each docs workflow. You can see it tested
here:

Sway: FuelLabs/sway#5369
Fuelup: FuelLabs/fuelup#535
Specs: FuelLabs/fuel-specs#539
Fuels-rs: FuelLabs/fuels-rs#1224
Fuels-ts: FuelLabs/fuels-ts#1484
Wallet: FuelLabs/fuels-wallet#987
Indexer: FuelLabs/fuel-indexer#1496
GraphQL: FuelLabs/fuel-graphql-docs#25
@sarahschwartz sarahschwartz marked this pull request as ready for review December 7, 2023 21:48
LuizAsFight
LuizAsFight previously approved these changes Dec 8, 2023
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work here !

@sarahschwartz can the list of words be in the CI itself inside of in this project ? then it can be easily reused across other projects

@LuizAsFight
Copy link
Contributor

also maybe this PR can wait for other PRs as RN we have going the

  • updates to beta-5
  • fixes on intermittent tests

after that will be ready to merge

@sarahschwartz
Copy link
Contributor Author

sarahschwartz commented Dec 8, 2023

It can wait as long as you don't make any other changes to the docs, since the docs workflow is broken without this.

And I thought about keeping the custom words list in one place, but I'm afraid that would slow down development since you would have to update 2 repos. Most tech terms need to be added to the list.

@luizstacio
Copy link
Member

It can wait as long as you don't make any other changes to the docs, since the docs workflow is broken without this.

And I thought about keeping the custom words list in one place, but I'm afraid that would slow down development since you would have to update 2 repos. Most tech terms need to be added to the list.

We could have a default list and allow a per repo bases list also. In this way we would make the CI simpler, and if we need to customize it would be fast.

@sarahschwartz
Copy link
Contributor Author

We could have a default list and allow a per repo bases list also. In this way we would make the CI simpler, and if we need to customize it would be fast.

That could work, I will follow up with another PR to do this later if that's ok.

@luizstacio luizstacio enabled auto-merge (squash) December 13, 2023 01:03
luizstacio
luizstacio previously approved these changes Dec 13, 2023
@luizstacio luizstacio dismissed stale reviews from LuizAsFight and themself via 297230e December 13, 2023 01:06
@luizstacio luizstacio merged commit d4b92bf into master Dec 13, 2023
13 checks passed
@luizstacio luizstacio deleted the sarah/spell-check branch December 13, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants