Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependence on jq in fuelup-init.sh #43

Closed
adlerjohn opened this issue May 28, 2022 · 0 comments · Fixed by #58
Closed

Remove dependence on jq in fuelup-init.sh #43

adlerjohn opened this issue May 28, 2022 · 0 comments · Fixed by #58
Assignees
@eightfilms
Labels
enhancement enhancement to a current feature good first issue Good for newcomers

Comments

@adlerjohn
Copy link
Contributor

adlerjohn commented May 28, 2022 •
edited
Loading

fuelup-init.sh currently depends on jq to parse the JSON response from GitHub for the latest release tag of fuelup. It would be nice to not have to depend on jq.

fuelup/fuelup-init.sh

Line 28 in 69b955c

_fuelup_version="$(curl -s https://api.github.com/repos/FuelLabs/fuelup/releases/latest | jq -r ".tag_name")"

A pure-shell implementation would be fragile and so is discouraged. An alternative would be to, on release, publish a single file to the gh-pages branch that contains the latest release tag. Then it can be downloaded with curl (which is already an unavoidable dependency).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eightfilms eightfilms

Labels
enhancement enhancement to a current feature good first issue Good for newcomers
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci for deploying fuelup version FuelLabs/fuelup
2 participants
@adlerjohn @eightfilms