replace jq with cut #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 30, 2022 11:34
mitchmindtree
suggested changes
May 30, 2022
fuelup-init.sh
Outdated
| @@ -25,8 +24,7 @@ main() { | |||
| mkdir -p "$FUELUP_DIR/bin" | |||
|
|
|||
| local _fuelup_version | |||
| _fuelup_version="$(curl -s https://api.github.com/repos/FuelLabs/fuelup/releases/latest | jq -r ".tag_name")" | |||
| _fuelup_version="$(echo "${_fuelup_version}" | cut -c 2-)" | |||
| _fuelup_version="$(curl -s https://api.github.com/repos/FuelLabs/fuelup/releases/latest | grep -r "tag_name" | cut -d "\"" -f4 | cut -c 2-)" | |||
There was a problem hiding this comment.
Suggested change
| _fuelup_version="$(curl -s https://api.github.com/repos/FuelLabs/fuelup/releases/latest | grep -r "tag_name" | cut -d "\"" -f4 | cut -c 2-)" | |
| _fuelup_version="$(curl -s https://api.github.com/repos/FuelLabs/fuelup/releases/latest | grep "tag_name" | cut -d "\"" -f4 | cut -c 2-)" |
Just tested this locally, but had to remove the recursive flag to get this to work. Otherwise looks good!
adlerjohn
reviewed
May 30, 2022
mitchmindtree
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
We use a combination of
grepandcutinstead ofjq."tag_name": "v0.1.2"The above is the output of the grep, then:
cut -d "\"" -f4 | cut -c 2-this splits the above string with the
"delimiter, getting thev0.1.2portion and cutting off thevThis may not also be the ideal way, but it's one solution as well, unless the solution described in the issue is preferred.