Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add forc-tx info #363

Merged
merged 4 commits into from Jan 27, 2023
Merged

feat: add forc-tx info #363

merged 4 commits into from Jan 27, 2023

Conversation

bingcicle
Copy link
Contributor

closes #351

@bingcicle bingcicle requested a review from a team January 26, 2023 09:31
@bingcicle bingcicle self-assigned this Jan 26, 2023
sdankel
sdankel approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One thing that could be good to is modify this test to loop though all of the forc plugins that have this same config (forc-doc, forc-tx, etc) and make the same assertions on each.

@bingcicle
Copy link
Contributor Author

@sdankel your link points to a empty line, but are you talking about this?

@bingcicle bingcicle enabled auto-merge (squash) January 27, 2023 01:22
@bingcicle
Copy link
Contributor Author

blocked by #369

@sdankel
Copy link
Member

sdankel commented Jan 27, 2023

@sdankel your link points to a empty line, but are you talking about this?

Yes!

@bingcicle bingcicle merged commit 08c237b into master Jan 27, 2023
@bingcicle bingcicle deleted the bing/add-forc-tx branch January 27, 2023 03:02
@bingcicle
Copy link
Contributor Author

@sdankel Thanks! Going to create a new issue for that 👍

This was referenced Jan 27, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchmindtree mitchmindtree mitchmindtree approved these changes

@sdankel sdankel sdankel approved these changes

Assignees

@bingcicle bingcicle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include the new forc-tx plugin from the Sway repo
3 participants
@bingcicle @sdankel @mitchmindtree