Dutch auction #78
Dutch auction #78
Conversation
Braqzen
added
New Feature
There was a problem hiding this comment.
This shouldn't be at the top level. Move it all to sway-applications/auctions/dutch-acution
Add a README.
Change "type of change" to "New Feature" instead of your custom "New Program" and add a space after "-" so that it looks like a bullet point.
Same with "Changes" for the bullet point and be more descriptive there.
You've linked to the issue, no need to copy and paste the same content into the "additional" section. remove that entirely.
Create a logo and insert it into the readme too.
I've probably made some mistakes / not reviewed it to the same extent that I would otherwise because of how messy this is. It's difficult to keep everything in mind. I will need to make additional reviews after changes are made.
Oh, you must use forc build to check your work and also forc fmt.
I've forgotten to mention but also this needs to be added to the CI in .github/workflows and the script too
Changed author Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
…pplications into 69-dutch-auction
No releases Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
Changed author Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
|
If everything looks good ill move on to the specification and readme |
| "auctions/english-auction", | ||
| "auctions/dutch-auction", |
There was a problem hiding this comment.
| "auctions/english-auction", | |
| "auctions/dutch-auction", | |
| "auctions/dutch-auction", | |
| "auctions/english-auction", |
| @@ -0,0 +1,9 @@ | |||
| # Overview | |||
There was a problem hiding this comment.
I suggest looking at the other README files and adjusting this one to contain a higher level structure / scope / content of the auctions as this only has a few lines / bullet points. It's too barebones.
There was a problem hiding this comment.
I would check the repo to see if this is even needed or if a repo level gitignore already contains there
| license = "Apache-2.0" | ||
|
|
||
| [dependencies] | ||
| fuels = { version = "0.38.1", features = ["fuel-core-lib"] } |
There was a problem hiding this comment.
I would bump all versions to be 0.41.0
| @@ -0,0 +1,9 @@ | |||
| # Overview | |||
There was a problem hiding this comment.
I would model the english auction docs for this file
|
|
||
| // retrieving active_auctions_of_author and auctions_of_author and auction_count before | ||
| let auction_count_before = auction_count(&instance).await; | ||
| let active_auctions_of_author_before = |
There was a problem hiding this comment.
This creation of an identity is being used repeatedly, I would wrap it into a function
| @@ -0,0 +1,11 @@ | |||
| pub mod active_auctions_of_author; | |||
| pub mod utils; | ||
|
|
||
| pub mod functions; |
There was a problem hiding this comment.
| pub mod utils; | |
| pub mod functions; | |
| pub mod functions; | |
| pub mod utils; |
| @@ -0,0 +1,177 @@ | |||
| use fuels::{prelude::*, types::Identity}; | |||
| (DutchAuction::new(id, wallet.clone()), wallet) | ||
| } | ||
|
|
||
| pub async fn active_auctions_of_author(instance: &DutchAuction, author: Identity) -> Vec<u64> { |
There was a problem hiding this comment.
I'd create a setup.rs for the setup and an interface dir which splits the content into core / info functionality. Take a look at the other apps for examples of how to do this
|
Is this still being developed? |
Not by me, someone can take over if they want |
|
Closed as this is no longer being worked on |
Summary
Type of change
Changes
Related Issues
Closes #69