-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgradeable contracts using proxies. #39
base: master
Are you sure you want to change the base?
Conversation
name = "implementation" | ||
|
||
[proxy] | ||
enabled = true # Undecided if we really need this flag yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think removing this makes sense, as absence or existence of [proxy]
table can be used to deduce this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess setting this to false would allow you to deploy the contract for testing purposes before generating and committing to the proxy contract.
Users could always comment out [proxy]
but this might make that more explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm you mean to test the implementation contract right? if so sounds good to me. Another option to infer the enabled = true
if the table is there, and for testing users can use enabled = false
or we can explicitly require the field to be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw I think having them comment it out for that behavior (or run a specific flag) looks more correct.
[rendered]