Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the hash test #1490 #1492

Closed
mohammadfawaz opened this issue May 6, 2022 · 2 comments
Closed

Expand the hash test #1490 #1492

mohammadfawaz opened this issue May 6, 2022 · 2 comments
Assignees
@Braqzen
Labels
good first issue Good for newcomers lib: std Standard library testing General testing

Comments

@mohammadfawaz
Copy link
Contributor

#1490 adds a new test for the hash library from lib-std. That test is quite small and needs to be expanded to test all hash functions and validate their output against Rust.
@mohammadfawaz mohammadfawaz added lib: std Standard library testing General testing labels May 6, 2022
@mohammadfawaz mohammadfawaz changed the title Expand the hash test added in https://github.com/FuelLabs/sway/pull/1490 Expand the hash test #1490 May 6, 2022
@adlerjohn adlerjohn added the good first issue Good for newcomers label May 6, 2022
@mohammadfawaz mohammadfawaz mentioned this issue May 14, 2022
Merged
@mohammadfawaz
Copy link
Contributor Author

@Braqzen can this be closed now?

@Braqzen
Copy link
Contributor

Braqzen commented May 23, 2022

@mohammadfawaz yup, all of the tests are now done via the sha256 and keccak256 issues. Those cover all of the types including more complex structs.

@Braqzen Braqzen closed this as completed May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Braqzen Braqzen

Labels
good first issue Good for newcomers lib: std Standard library testing General testing
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adlerjohn @mohammadfawaz @Braqzen