New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added generic sha256 #1544
Added generic sha256 #1544
Conversation
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
The implementation looks good :) |
Sure, I already have some assertions that can be compared to |
The unfortunate only way to test hashing is to go on some online hashing site and put in a few values, then use those values as test vectors. |
Can we not use a hashing library such as https://docs.rs/sha2/latest/sha2/ in the hashing test? That's what I was hoping we'd accomplish for #1492, and this PR seems like the perfect place to knock that issue out. Also, we can now deprecate (or even remove) |
Ah, I meant if you wanted to test using only a Sway script and no Rust harness. |
…braqzen-1511 Merging master into local branch, pulling in latest work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR. I appreciate the thorough testing!
LGTM! I'd like another set of eyes to review this and I'll approve after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Closes #1511