Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic stack type hashing #1511

Closed
Tracked by #1553
adlerjohn opened this issue May 10, 2022 · 3 comments · Fixed by #1544
Closed
Tracked by #1553

Generic stack type hashing #1511

adlerjohn opened this issue May 10, 2022 · 3 comments · Fixed by #1544
Assignees
@Braqzen
Labels
enhancement New feature or request good first issue Good for newcomers lib: std Standard library

Comments

@adlerjohn
Copy link
Contributor

adlerjohn commented May 10, 2022 •
edited
Loading

Related: #823

Outline:

Check if type is a reference type with is_reference_type().

If not. then it's in the register:

  1. Grow stack with CFEI by one word.
  2. Save value in register to memory with SW.
  3. Hash with S256.

If yes:

  1. Get size with size_of().
  2. Hash with S256.
@adlerjohn adlerjohn added enhancement New feature or request good first issue Good for newcomers lib: std Standard library labels May 10, 2022
@mohammadfawaz
Copy link
Contributor

mohammadfawaz commented May 10, 2022 •
edited
Loading

Actually I'll be working in this in the coming weeks. I need it to implement generic mappings.

@adlerjohn
Copy link
Contributor Author

@Braqzen volunteered as tribute since this is kind of needed for the multisig to hash "actions."

@mohammadfawaz
Copy link
Contributor

Ah excellent. We'll be in touch then!

@Braqzen Braqzen self-assigned this May 13, 2022
@Braqzen Braqzen mentioned this issue May 13, 2022
Merged
@adlerjohn adlerjohn mentioned this issue May 14, 2022
Closed
This was referenced May 15, 2022
Closed
Closed
@adlerjohn adlerjohn mentioned this issue May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Braqzen Braqzen

Labels
enhancement New feature or request good first issue Good for newcomers lib: std Standard library
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added generic sha256 FuelLabs/sway
3 participants
@adlerjohn @mohammadfawaz @Braqzen