Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackageManifestFile verification never gets called #4411

Closed
kayagokalp opened this issue Apr 7, 2023 · 0 comments · Fixed by #4412
Closed

PackageManifestFile verification never gets called #4411

kayagokalp opened this issue Apr 7, 2023 · 0 comments · Fixed by #4412
Assignees
@kayagokalp
Labels
bug Something isn't working forc-pkg Everything related to the `forc-pkg` crate.

Comments

@kayagokalp
Copy link
Member

kayagokalp commented Apr 7, 2023 •
edited
Loading

Realized while working on #4072. PackageManifest::verification is called while getting generated (in ::new()) but PackageManifestFile does not do that and we don't have any callers to it as well.

Trying to enable the verification makes cargo test failing as forc_deploy::op tests we have try to read manifest files without full projects which makes the verification failing (since entry point file is missing).
@kayagokalp kayagokalp added bug Something isn't working forc-pkg Everything related to the `forc-pkg` crate. labels Apr 7, 2023
@kayagokalp kayagokalp self-assigned this Apr 7, 2023
@kayagokalp kayagokalp mentioned this issue Apr 7, 2023
Merged
7 tasks
kayagokalp added a commit that referenced this issue Apr 11, 2023
@kayagokalp
fix: enable package manifest file verification during `PackageManifes…
4c83b19 
…tFile::new` (#4412)

## Description
Fixes missing validation step in the `PackageManifestFile::new()`.
closes #4411.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
bug Something isn't working forc-pkg Everything related to the `forc-pkg` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enable package manifest file verification during PackageManifestFile::new FuelLabs/sway
1 participant
@kayagokalp