u256 log implementation rounding errors
#6126
Comments
|
Do we have an example? So I can understand a little bit better the peoblem. |
|
Blocked by #6143 |
8 tasks
IGI-111
added a commit
that referenced
this issue
Jul 1, 2024
## Description The current implementation of u256 logarithm will frequently output wrong values due to rounding errors Closes #6126 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: IGI-111 <igi-111@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When calling
logon theu256type rounding error can occur. This should be addressed or a warning should be added.The text was updated successfully, but these errors were encountered: