Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use checked_mod in ir operations to avoid panics #6150

Closed
IGI-111 opened this issue Jun 20, 2024 · 1 comment
Closed

Use checked_mod in ir operations to avoid panics #6150

IGI-111 opened this issue Jun 20, 2024 · 1 comment
Assignees
@vaivaswatha
Labels
audit-report Related to the audit report bug Something isn't working compiler: ir IRgen and sway-ir including optimization passes compiler: optimization IR Optimization Passes

Comments

@IGI-111
Copy link
Contributor

IGI-111 commented Jun 20, 2024

We should use checked_mod for the Mod operations to avoid panics. This also makes sense in the context of fuel since the flag may allow division by 0 to not abort execution.
@IGI-111 IGI-111 added bug Something isn't working compiler: ir IRgen and sway-ir including optimization passes compiler: optimization IR Optimization Passes labels Jun 20, 2024
@vaivaswatha
Copy link
Contributor

Already fixed by #6112. Closing.

@IGI-111 IGI-111 added the audit-report Related to the audit report label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaivaswatha vaivaswatha

Labels
audit-report Related to the audit report bug Something isn't working compiler: ir IRgen and sway-ir including optimization passes compiler: optimization IR Optimization Passes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vaivaswatha @IGI-111