Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mod by zero constant folding #6112

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Jun 12, 2024

Description

This PR fixes a problem with constant folding optimization pass with the mod operator. Unfortunately, we were not checking that the RHS was not zero. So expressions like mod 1 0 were packing the compiler.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested a review from a team as a code owner June 12, 2024 15:09
@xunilrj xunilrj force-pushed the xunilrj/fix-const-fold-mod-by-zero branch from c48122e to e778558 Compare June 12, 2024 15:11
@xunilrj xunilrj self-assigned this Jun 13, 2024
@IGI-111 IGI-111 enabled auto-merge (squash) June 13, 2024 08:45
@IGI-111 IGI-111 requested a review from a team June 13, 2024 08:46
@IGI-111 IGI-111 merged commit be5e134 into master Jun 13, 2024
37 checks passed
@IGI-111 IGI-111 deleted the xunilrj/fix-const-fold-mod-by-zero branch June 13, 2024 16:40
@martianlazarus
Copy link

hi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants