Enable GitHub-based remote dependencies #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes enable users to specify dependencies that are
hosted on GitHub by defining the property `git = ":url"`
in the dependency, e.g:
```
std = { git = ":url"}
```
For now the GitHub repo must be public.
It also enables users to specify either a branch or a versioned tag
along with the git repo, e.g:
```
std = { git = ":url", branch = "my-branch"}
```
and:
```
std = { git = ":url", version = "0.0.1"}
```
As of now, version takes precedence over branch references.
These remote dependencies will be installed under `~/forc/`.
If no version/branch is specified, it will download the default
branch at the latest commit.
Future work includes:
- A command to check if there are remote changes to the dependency
- A command to download updates to the dependencies
digorithm
changed the title
digorithm
changed the title
4 tasks
sezna
reviewed
Jun 29, 2021
sezna
reviewed
Jun 29, 2021
sezna
reviewed
Jun 29, 2021
adlerjohn
reviewed
Jun 29, 2021
| } | ||
| } | ||
|
|
||
| fn download_tarball(url: &str, out_dir: &str) -> Result<String> { |
There was a problem hiding this comment.
Do the error messages in this function include the URL/location/agent, etc.? If not, can they be added?
There was a problem hiding this comment.
Good point, will look into that!
|
The description currently says
Should this be |
Yup, exactly. Was a typo, thanks! |
This was referenced Jun 30, 2021
Merged
adlerjohn
previously approved these changes
Jul 1, 2021
leviathanbeak
previously approved these changes
Jul 2, 2021
sezna
previously approved these changes
Jul 2, 2021
digorithm
dismissed stale reviews from sezna, leviathanbeak, and adlerjohn
via
82b6c98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #67
These changes enable users to specify dependencies that are
hosted on GitHub by defining the property
git = ":url"in the dependency, e.g:
For now the GitHub repo must be public.
It also enables users to specify either a branch or a versioned tag
along with the git repo, e.g:
and:
As of now, version takes precedence over branch references.
These remote dependencies will be installed under
~/.forc/.If no version/branch is specified, it will download the default
branch at the latest commit.
Future work includes:
forc_build.rsfile and creating proper dependency-related abstractions.