Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhelpful error with incorrect number of type arguments. #1089

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fix unhelpful error with incorrect number of type arguments. #1089

merged 1 commit into from
Mar 29, 2022

Conversation

emilyaherbert
Copy link
Contributor

Closes #1030

@emilyaherbert emilyaherbert self-assigned this Mar 29, 2022
@emilyaherbert emilyaherbert added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged labels Mar 29, 2022
@emilyaherbert emilyaherbert marked this pull request as ready for review March 29, 2022 07:08
otrho
otrho approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@otrho otrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

adlerjohn
adlerjohn approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@emilyaherbert emilyaherbert merged commit 1943136 into master Mar 29, 2022
@emilyaherbert emilyaherbert deleted the emilyaherbert-1030/generics-unhelpful-error branch March 29, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otrho otrho otrho approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

@sezna sezna Awaiting requested review from sezna

@canndrew canndrew Awaiting requested review from canndrew

@mohammadfawaz mohammadfawaz Awaiting requested review from mohammadfawaz

Assignees

@emilyaherbert emilyaherbert

Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhelpful error when using too few generic arguments
3 participants
@emilyaherbert @otrho @adlerjohn