Improve strings for IR. #1113
Merged
Improve strings for IR. #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print any const args to `extract_value` and only print const values once ever.
It used to be `{ ty0 | ty1 | ... }` but a single variant union would
just be `{ ty }`. This is indistinguishable from a single field struct
or tuple so now it's `( ty0 | ty1 | ... )`.
Assume that strings are always used by reference and so their stack size will always be that of one word. IR treats strings as a vector of bytes to avoid UTF-8 trickiness. They may still be UTF-8 strings of course, but the IR doesn't care either way.
otrho
added
bug
|
Hrmm, looking at the diff myself and thinking the new union syntax could be confused with unit. It's all working at the moment, so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one of the final tasks on my list and now we're yet again passing E2E with IR.
I've decided to just represent strings as
Vec<u8>in the IR, there's no point in trying to get tricky with UTF-8 support. UTF-8 strings will still 'work', but in IR they're serialised with escaped hex representation.I also updated the serialiser so it doesn't write out constants which are re-used more than once. And I changed the syntax for unions to be less ambiguous.