Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement function selector construction for function declarations #113

Merged
merged 2 commits into from Jul 7, 2021
Merged

Implement function selector construction for function declarations #113

merged 2 commits into from Jul 7, 2021

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Jul 6, 2021

Closes #96

This PR implements the function selectors in the manner discussed in the issue linked above. Note that this PR does not integrate these selectors into any actual use cases, it merely consists of constructing them from TypedFunctionDeclarations and a few tests.

@sezna sezna self-assigned this Jul 6, 2021
@adlerjohn adlerjohn added the compiler General compiler. Should eventually become more specific as the issue is triaged label Jul 7, 2021
adlerjohn
adlerjohn approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR seems to implement #96 as described. If we need to change the string later for whatever reason, that can always be done without affecting the rest of the compiler, so nbd if it's not perfect.

@sezna sezna merged commit 6aa5fb7 into master Jul 7, 2021
@sezna sezna deleted the function_selectors branch July 7, 2021 00:15
leviathanbeak pushed a commit that referenced this pull request Jul 7, 2021
@sezna @leviathanbeak
Implement function selector construction for function declarations (#113
1632f68 
)

* Implement function selector construction for function declarations

* fmt and remove return selectors

Co-authored-by: Alexander Hansen <alexanderhansen@Alexanders-MacBook-Pro.local>
@adlerjohn adlerjohn mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@vlopes11 vlopes11 Awaiting requested review from vlopes11

@SilentCicero SilentCicero Awaiting requested review from SilentCicero

Assignees

@sezna sezna

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unique function identifiers for use in the function selector in contracts
2 participants
@sezna @adlerjohn