Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and clean up forc reference docs. #2233

Merged
merged 4 commits into from Jul 6, 2022
Merged

Fix and clean up forc reference docs. #2233

merged 4 commits into from Jul 6, 2022

Conversation

adlerjohn
Copy link
Contributor

@adlerjohn adlerjohn commented Jul 5, 2022 •
edited

  • Current forc new doc page reads "Create a new Forc project at". Fixed to show "Create a new Forc project at <path>."
  • Fix headers to have a leading newline and no :, etc.
  • Minor language improvements.

@adlerjohn adlerjohn added forc The Sway Book Everything to do with the Sway Book labels Jul 5, 2022
@adlerjohn adlerjohn self-assigned this Jul 5, 2022
@adlerjohn adlerjohn marked this pull request as ready for review July 5, 2022 23:31
ra0x3
ra0x3 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adlerjohn adlerjohn enabled auto-merge (squash) July 6, 2022 00:41
@adlerjohn adlerjohn merged commit 9dc04fc into master Jul 6, 2022
@adlerjohn adlerjohn deleted the adlerjohn/fix-forc-docs branch July 6, 2022 00:49
r-sitko pushed a commit to r-sitko/sway that referenced this pull request Jul 6, 2022
@adlerjohn @r-sitko
Fix and clean up forc reference docs. (FuelLabs#2233)
4e4f523 
* Fix and clean up forc reference docs.

* Revert path surround change.

* Surround with backticks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ra0x3 ra0x3 ra0x3 approved these changes

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@bingcicle bingcicle Awaiting requested review from bingcicle

@mitchmindtree mitchmindtree Awaiting requested review from mitchmindtree

Assignees

@adlerjohn adlerjohn

Labels
forc The Sway Book Everything to do with the Sway Book
Projects
Fuel Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adlerjohn @ra0x3 @mohammadfawaz