Add flag to reverse errors

[gr00vytvniks]

closes #3860

[gr00vytvniks]

hey @kayagokalp I made the changes you requested, I tried running forc build after adding some errors to examples/counter and I got this error.

error
  --> /Users/mitchmackert/Code/sway/sway-lib-core/src/ops.sw:11:9
   |
 9 | 
10 |     fn add(self, other: Self) -> Self {
11 |         __add(self, other)
   |         ^^^^^ Identifiers cannot begin with a double underscore, as that naming convention is reserved for compiler intrinsics.
12 |     }
13 | }
   |
____

would you mind giving me steps to test this correctly? I think I am looking at this the wrong way

[kayagokalp]

hey @gr00vytvniks thanks for the PR, the error looks odd. Can you make a rebase/merge master as you shouldn't have any lock file is the counter folder as we recently changed that folder to be a workspace, see. This type of core compilation errors can be seen with master forc depending on a released version of std/core. Can you make sure that in examples/counter/Forc.toml you actually depend on local std. You should have something like this in the Forc.toml:

[dependencies]
std = { path = "../../sway-lib-std" }

You should be able to test this with a template project by adding a couple of compile errors. Let me know if you are unsure/stuck 👍

[gr00vytvniks]

hey @gr00vytvniks thanks for the PR, the error looks odd. Can you make a rebase/merge master as you shouldn't have any lock file is the counter folder as we recently changed that folder to be a workspace, see. This type of core compilation errors can be seen with master forc depending on a released version of std/core. Can you make sure that in examples/counter/Forc.toml you actually depend on local std. You should have something like this in the Forc.toml:

[dependencies]
std = { path = "../../sway-lib-std" }

You should be able to test this with a template project by adding a couple of compile errors. Let me know if you are unsure/stuck 👍

Hey @kayagokalp, The error came from a collision between an old fuelup binary and a cargo binary.

[gr00vytvniks]

Hey @kayagokalp, I added a debug build profile like the book instructed but it is giving me this warning.

 ~/Code/sway/examples/counter/ [gr00vytvniks/reverse-errors*] forc build
  WARNING! unused manifest key: build-profiles

[gr00vytvniks]

I went ahead and just changed the default in debug() to true and this was the output :) Should we leave the default as true, or leave it up to the user?

error
  --> /Users/mitchmackert/Code/sway/examples/counter/src/main.sw:23:42
   |
21 | 
22 |     #[storage(read, write)]
23 |     fn increment_counter(amount: u64) -> u8 {
   |                                          ^^ expected: u64 
found:    u8 
help:     The definition of this function must match the one in the ABI "TestContract" declaration.
24 |         let incremented = storage.counter + amount;
25 |         storage.counter = incremented;
   |
____

error
  --> /Users/mitchmackert/Code/sway/examples/counter/src/main.sw:17:42
   |
15 | 
16 |     #[storage(write)]
17 |     fn initialize_counter(value: u64) -> u32 {
   |                                          ^^^ expected: u64 
found:    u32 
help:     The definition of this function must match the one in the ABI "TestContract" declaration.
18 |         storage.counter = value;
19 |         value
   |
____

  Aborting due to 2 errors.
Error: Failed to compile counter

[kayagokalp]

We should not revert it in any build profile imo. This is not something everyone would be using it is more niche command that some people may end-up using.

So we should not revert by default as it would be unexpected for the users. We should be able to use this feature with the flag forc build --reverse-errors etc.

[nfurfaro]

Thanks!

[eureka-cpu]

Looks like there's a problem with the formatting of the examples/counter/Forc.toml file. Also some of the should_fail e2e tests are failing incorrectly (not sure if it's related, may just need to re-run the job).

[eureka-cpu]

Happy to approve this once merge conflicts are resolved and @kayagokalp gives his approval

[eureka-cpu]

As a follow up PR, you could update the documentation so that developers will know how to use this feature. ie as part of a BuildProfile or just via --reverse-order(Not sure what name you guys landed on).

[eureka-cpu]

Haven't tested yet but there's one thing that seems out of place if you wouldn't mind addressing it. After that I'll pull this branch and test it out!

[eureka-cpu]

🚢

[JoshuaBatty]

Thanks for this. just some last merge conflicts @gr00vytvniks