Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ref mut parameter checking to apply to all function parameters. #4442

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Fix ref mut parameter checking to apply to all function parameters. #4442

merged 1 commit into from
Apr 15, 2023

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Apr 14, 2023

Closes #4438.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged P: critical Should be looked at before anything else compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Apr 14, 2023
@tritao tritao self-assigned this Apr 14, 2023
@tritao tritao marked this pull request as ready for review April 14, 2023 18:18
@tritao tritao requested review from a team and removed request for a team April 14, 2023 18:18
@tritao tritao marked this pull request as draft April 14, 2023 18:19
@tritao tritao requested a review from a team April 14, 2023 18:48
@tritao tritao marked this pull request as ready for review April 14, 2023 18:48
mohammadfawaz
mohammadfawaz approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@mohammadfawaz mohammadfawaz requested a review from a team April 15, 2023 01:11
@mohammadfawaz mohammadfawaz merged commit 70840ea into FuelLabs:master Apr 15, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaivaswatha vaivaswatha vaivaswatha approved these changes

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

Assignees

@tritao tritao

Labels
bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged P: critical Should be looked at before anything else
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal compiler error: Verification failed: Struct access must be to a pointer value, not a { string<10> }
3 participants
@tritao @vaivaswatha @mohammadfawaz