Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves error message when log is used in predicate. #4484

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Improves error message when log is used in predicate. #4484

merged 2 commits into from
Apr 24, 2023

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Apr 24, 2023 •
edited
Loading

Description

Previously when log was used in predicate the error message would be: Internal compiler error: Unable to determine ID for log instance.

Now the error message is:
Using intrinsic "log" in a predicate is not allowed.

Closes #4415

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal
Improves error message when log is used in predicate.
501df7a 
Previously when log was used in predicate the error message would be:
`Internal compiler error: Unable to determine ID for log instance.`

Now the error message is:
`Using intrinsic "log" in a predicate is not allowed.`

Closes #4415
@esdrubal esdrubal added bug Something isn't working P: critical Should be looked at before anything else compiler: ui Mostly compiler messages labels Apr 24, 2023
@esdrubal esdrubal self-assigned this Apr 24, 2023
@esdrubal esdrubal requested a review from a team April 24, 2023 10:03
kayagokalp
kayagokalp approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally & lgtm

@tritao tritao enabled auto-merge (squash) April 24, 2023 10:13
@tritao tritao merged commit 386f58d into master Apr 24, 2023
25 checks passed
@tritao tritao deleted the esdrubal/4415_predicate_log branch April 24, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritao tritao tritao approved these changes

@kayagokalp kayagokalp kayagokalp approved these changes

Assignees

@esdrubal esdrubal

Labels
bug Something isn't working compiler: ui Mostly compiler messages P: critical Should be looked at before anything else
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal compiler error: Unable to determine ID for log instance. during building of predicate
3 participants
@esdrubal @tritao @kayagokalp