-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option and Result variants in prelude #4504
Conversation
fd99fd4
to
58a3d3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me just one thing. Can you update the prelude.md
as well to include Option
and Result
now.
58a3d3d
to
e556680
Compare
The types were already in there but I updated it to clarify that we also include the variants. |
This also handles ambiguities in cases where a lone ident is either a variable or a variant; or a variable declaration or an enum scrutinee. Fix #4480
e556680
to
f0f854b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
This also handles ambiguities in cases where a lone ident is either a variable or a variant; or a variable declaration or an enum scrutinee.
Fix #4480
Checklist
Breaking*
orNew Feature
labels where relevant.