Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aggressive predicate inlining #4572

Merged
merged 1 commit into from
May 19, 2023
Merged

Remove aggressive predicate inlining #4572

merged 1 commit into from
May 19, 2023

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented May 18, 2023 •
edited
Loading

Description

Now that jumps are allowed in predicates, this change uses the regular inlining pass and its heuristics instead of just inlining everything, which slowed down compilation significantly.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111
Remove aggressive predicate inlining
7a2f283 
Now that jumps are allowed in predicates, this change uses the regular
inlining pass and its heuristics instead of just inlining everything,
which slowed down compilation significantly.
@IGI-111 IGI-111 added bug Something isn't working compiler: optimization IR Optimization Passes labels May 18, 2023
@IGI-111 IGI-111 self-assigned this May 18, 2023
@IGI-111 IGI-111 requested review from a team and vaivaswatha May 19, 2023 02:27
@IGI-111 IGI-111 marked this pull request as ready for review May 19, 2023 02:27
@IGI-111 IGI-111 requested a review from a team May 19, 2023 02:37
@IGI-111 IGI-111 merged commit 3445cd1 into master May 19, 2023
26 checks passed
@IGI-111 IGI-111 deleted the IGI-111/remove-predicate-inlining branch May 19, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritao tritao tritao approved these changes

@vaivaswatha vaivaswatha vaivaswatha approved these changes

Assignees

@IGI-111 IGI-111

Labels
bug Something isn't working compiler: optimization IR Optimization Passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IGI-111 @tritao @vaivaswatha