Update std-lib to reflect new granular asset minting spec #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think worths talking discussing if we should have two libraries in the std lib, one with the same api as before (single token), and one with the above multi-token api. Many usecases only really need one token, and thus would make the new api overtly verbose |
|
+1 on @SwayStar123's comment Would be nice to keep |
dmihal
reviewed
Jul 12, 2023
SwayStar123
reviewed
Jul 14, 2023
bitzoic
added
the
breaking
xgreenx
added a commit
that referenced
this pull request
Jul 26, 2023
Voxelot
added a commit
to FuelLabs/fuel-specs
that referenced
this pull request
Aug 7, 2023
### Abstract This PR introduces granular asset minting which would enable sub identifiers to be included at asset creation. These sub identifiers can include important metadata and be used to enable native level NFTs. **This adds:** - A new asset ID construction (which incorporates the contract ID and the sub asset ID). - New receipt logs for minting and burning which are helpful for indexing. - Changes to the MINT and BURN opcodes. ### Cons - This removes the nice feature that asset IDs are the contract ID. ### Pros - Native level UTXO based NFTs. - Single contract multi-asset pools (useful for common AMM designs). Implementation tickets/PRs: - FuelLabs/fuel-vm#496 - FuelLabs/fuels-ts#1067 - FuelLabs/fuel-indexer#1012 - FuelLabs/sway#4651 --------- Co-authored-by: Brandon Kite <brandonkite92@gmail.com> Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
|
Closed by #4821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to std-lib to support multi-asset native token contracts with the introduction of a sub id.
Closes #4644
Checklist
Breaking*orNew Featurelabels where relevant.