Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forc-fmt panic when lexing fails #5011

Merged
merged 10 commits into from Aug 25, 2023
Merged

Fix forc-fmt panic when lexing fails #5011

merged 10 commits into from Aug 25, 2023

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Aug 24, 2023

Description

Closes #5010

Now instead of a panic, the user sees this:

image

With debug logging they can see the compiler error, or they can simply run the compiler.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review August 24, 2023 00:55
@sdankel sdankel requested a review from a team August 24, 2023 01:29
@sdankel sdankel enabled auto-merge (squash) August 24, 2023 04:00
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@JoshuaBatty JoshuaBatty requested a review from a team August 24, 2023 23:30
@sdankel sdankel merged commit 985e055 into master Aug 25, 2023
27 checks passed
@sdankel sdankel deleted the sophie/5010 branch August 25, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forc-fmt panic when file cannot be lexed
3 participants