Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in forc-fmt with special chars #5014

Merged
merged 26 commits into from Aug 28, 2023
Merged

Fix panic in forc-fmt with special chars #5014

merged 26 commits into from Aug 28, 2023

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Aug 24, 2023

Description

Closes #5013

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel requested review from a team and removed request for a team August 24, 2023 03:24
@sdankel sdankel changed the title Sophie/5013 Fix panic in forc-fmt with special chars Aug 24, 2023
@sdankel sdankel marked this pull request as ready for review August 24, 2023 19:21
@sdankel sdankel requested a review from a team August 24, 2023 21:08
@JoshuaBatty JoshuaBatty requested a review from a team August 24, 2023 23:33
@JoshuaBatty
Copy link
Member

nice, just a small clippy error otherwise happy to approve.

JoshuaBatty
JoshuaBatty previously approved these changes Aug 25, 2023
View reviewed changes
@JoshuaBatty JoshuaBatty requested a review from a team August 25, 2023 01:00
@sdankel sdankel enabled auto-merge (squash) August 25, 2023 20:51
JoshuaBatty
JoshuaBatty previously approved these changes Aug 26, 2023
View reviewed changes
@JoshuaBatty JoshuaBatty requested a review from a team August 26, 2023 06:30
kayagokalp
kayagokalp previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this! LGTM :) left a single nit but more like a preference thing so nothing to block. Feel free to discard that comment

swayfmt/src/utils/map/newline.rs Outdated Show resolved Hide resolved
@sdankel sdankel dismissed stale reviews from kayagokalp and JoshuaBatty via fd67228 August 28, 2023 21:20
@sdankel sdankel merged commit 0c045be into master Aug 28, 2023
31 checks passed
@sdankel sdankel deleted the sophie/5013 branch August 28, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@kayagokalp kayagokalp kayagokalp approved these changes

Assignees

@sdankel sdankel

Labels
formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forc-fmt panics with utf chars in comment
3 participants
@sdankel @JoshuaBatty @kayagokalp