Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "this" method to ContractId #5099

Merged
merged 1 commit into from Sep 8, 2023
Merged

Add a "this" method to ContractId #5099

merged 1 commit into from Sep 8, 2023

Conversation

SwayStar123
Copy link
Member

Description

Adds a ContractId::this() method, equivalent to std::call_frames::contract_id(). For ease of use.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 self-assigned this Sep 8, 2023
@SwayStar123 SwayStar123 added enhancement New feature or request lib: std Standard library labels Sep 8, 2023
@SwayStar123 SwayStar123 marked this pull request as ready for review September 8, 2023 09:57
sway-lib-std/src/call_frames.sw Show resolved Hide resolved
@SwayStar123 SwayStar123 merged commit 5f9f22b into master Sep 8, 2023
32 checks passed
@SwayStar123 SwayStar123 deleted the this_contract_id branch September 8, 2023 10:47
@K1-R1
Copy link
Contributor

K1-R1 commented Sep 8, 2023

Late to the discussion, but imo the best syntax is:
let this_contract = contract_id();
I would instead advocate for the removal of the function contract_id() from call_frames and for this new function in the contract_id lib to be renamed contract_id()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants