Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type checking refactorings and optimizations #5113

Merged
merged 8 commits into from Sep 13, 2023
Merged

Type checking refactorings and optimizations #5113

merged 8 commits into from Sep 13, 2023

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Sep 12, 2023

Description

This PR splits a bunch of associated commits out of the type checking refactoring work to make it easier to review and make it easier for me to manage the rest of the PRs in the future.

Nothing too major yet, just some refactoring, optimizations and debugging helpers.

Split processing of impl methods in two phases.

Split function monomorphization out of method name resolving.

Migrate TyProgramKind main function to decl engine ids.

Add a method to pretty print decl ids to the DeclEngine.

Optimize decl id insertion in method application.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Sep 12, 2023
@tritao tritao requested a review from a team September 12, 2023 14:09
@tritao tritao self-assigned this Sep 12, 2023
@tritao tritao force-pushed the misc-refactorings branch 3 times, most recently from 8fcff52 to ffe7857 Compare September 12, 2023 14:25
@tritao tritao changed the title Misc refactorings Type checking refactoringand optimizations Sep 12, 2023
@tritao tritao changed the title Type checking refactoringand optimizations Type checking refactorings and optimizations Sep 12, 2023
@tritao tritao marked this pull request as ready for review September 12, 2023 18:53
IGI-111
IGI-111 previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nipick, otherwise looks good to me.

@IGI-111 IGI-111 requested a review from a team September 13, 2023 11:16
@tritao @IGI-111
Update sway-core/src/language/ty/declaration/function.rs
cb1baa6 
Co-authored-by: IGI-111 <igi-111@protonmail.com>
@tritao tritao enabled auto-merge (squash) September 13, 2023 11:49
@tritao tritao requested a review from IGI-111 September 13, 2023 11:50
@IGI-111 IGI-111 requested a review from a team September 13, 2023 11:51
@tritao tritao merged commit 53d0a75 into FuelLabs:master Sep 13, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esdrubal esdrubal esdrubal approved these changes

@IGI-111 IGI-111 IGI-111 approved these changes

Assignees

@tritao tritao

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tritao @esdrubal @IGI-111