Fix rename for alias and function prefixes #5118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4982
There were actually two issues here.
I added a test that covers both. I also noticed that the other rename tests do not assert anything about the response. I think we should at least assert the number of changes is correct to prevent regressions. I can add that to this PR or open a follow up.
This changes the behavior of go to the definition of a function call prefix. Previously it would go to the impl of the prefix where the function was implemented. Now it takes you to the definition of the struct/enum, or the top of the module instead. The new behavior is more similar to rust-analyzer.
Checklist
Breaking*
orNew Feature
labels where relevant.