-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable storing of a Vec
with the StorageVec
type
#5123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K1-R1
previously approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SwayStar123
requested changes
Sep 19, 2023
SwayStar123
previously approved these changes
Sep 19, 2023
IGI-111
previously approved these changes
Sep 26, 2023
SwayStar123
approved these changes
Sep 26, 2023
K1-R1
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
May cause existing user code to break. Requires a minor or major release.
enhancement
New feature or request
lib: std
Standard library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
StorageVec
andVec
do not have any relation with one another. This PR takes advantage of the recent optimization and refactoring done to the Storage APIread()
andwrite()
functions in #4795 and enables the storing of aVec
using theStorageVec
type.To do this, the
StorageVec
now stores things sequentially rather than a different key for every element. Due to the optimizations done to the Storage API, this has become feasible as we can now load a single element of the sequentialStorageVec
.The storing of elements sequentially mimics the existing
Vec
, allowing us to store it as araw_slice
with a single read/write to storage as opposed to looping over theVec
and having n read/writes.It should be noted that due to #409, the storing of a
Vec
is written in theStorageVec
file. This is the resulting syntax:When this issue is resolved, this should be changed to a
From
implementation changing the syntax to:Closes #2439
Checklist
Breaking*
orNew Feature
labels where relevant.