Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expect to option and result #5431

Merged
merged 44 commits into from Apr 11, 2024
Merged

Add expect to option and result #5431

merged 44 commits into from Apr 11, 2024

Conversation

SwayStar123
Copy link
Member

Description

Adds the expect method to Option and Result type in the standard library

Closes #5322
Closes #5323

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 added enhancement New feature or request lib: std Standard library labels Jan 4, 2024
@SwayStar123 SwayStar123 self-assigned this Jan 4, 2024
@SwayStar123 SwayStar123 marked this pull request as ready for review February 14, 2024 14:17
K1-R1
K1-R1 previously approved these changes Feb 14, 2024
View reviewed changes
@SwayStar123 SwayStar123 dismissed stale reviews from K1-R1 and xunilrj via 282ebbb March 13, 2024 11:30
sdankel
sdankel previously approved these changes Mar 13, 2024
View reviewed changes
@SwayStar123
Copy link
Member Author

Blocked by #5735

@SwayStar123 SwayStar123 requested a review from K1-R1 April 8, 2024 13:38
@SwayStar123 SwayStar123 merged commit f869f22 into master Apr 11, 2024
32 checks passed
@SwayStar123 SwayStar123 deleted the expect_option_result branch April 11, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdankel sdankel sdankel approved these changes

@K1-R1 K1-R1 K1-R1 approved these changes

@xunilrj xunilrj xunilrj left review comments

@bitzoic bitzoic Awaiting requested review from bitzoic

Assignees

@SwayStar123 SwayStar123

Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add expect() to Option Add expect() to Result
5 participants
@SwayStar123 @xunilrj @sdankel @bitzoic @K1-R1