Fixes ReplaceDecls to no longer depend on filter hack.
#5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added
P: critical
esdrubal
force-pushed
the
esdrubal/fix_replace_decls
branch
2 times, most recently
from
e23f23c
to
0321952
Compare
`ReplaceDecls` was using a hack to replace some function refs based on the self function parameter, this didn't work for associated functions. Now DeclMapping sources also contain a typeid that guarantees that the replacement is done to the correct declaration in case we have nested trait methods with the same name replaced. Fixes #5504
IGI-111
reviewed
Feb 3, 2024
ironcev
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
LGTM. BDW, with this change implementingthe exact TyFunctionDecl::is_constructor method should be straightforward. The TODO I left in that method was exactly about the difficulty of determining the exact Self type for the method. I should give it a try and implement that TODO once this PR gets accepted 😄
tritao
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReplaceDeclswas using a hack to replace some function refs based onthe self function parameter, this didn't work for associated functions.
Now DeclMapping sources also contain a typeid that guarantees that the
replacement is done to the correct declaration in case we have nested
trait methods with the same name replaced.
Fixes #5504
Checklist
Breaking*orNew Featurelabels where relevant.