-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fig completions #5669
Conversation
Benchmark for 2f6d84aClick to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share the steps for manually testing this with fig?
Is it possible to write unit tests for this? It would be good to assert that the correct autocompletions file is created for each target.
Benchmark for 1ee427aClick to view benchmark
|
Benchmark for 4d43fdeClick to view benchmark
|
Benchmark for 33c14daClick to view benchmark
|
This is the first part of #5612, which will be split into several smaller PRs
Trailing dots are [rejected in fig's main repo](https://github.com/withfig/autocomplete/actions/runs/7978839646/job/21928919907?pr=2280)
The following command prints the typescript code add completion support (as it was added in a PR)
A following PR will add support for optional introspection with plugins (I have it working in the old PR) I also added unit tests and added the foundation for adding more tests for each command (for instance to test the upcoming PR with complete scripts for plugins). It will also skip if a given shell is not supported at runtime. |
Benchmark for 6ff4eb3Click to view benchmark
|
e81558f
to
ded72b0
Compare
Benchmark for 45c0a7eClick to view benchmark
|
Benchmark for fc5d770Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Benchmark for df2a65fClick to view benchmark
|
Benchmark for 7dcd5b9Click to view benchmark
|
Benchmark for a68dd66Click to view benchmark
|
Description
This fixes #5474
This is the first part of #5612, which will be split into several smaller PRs
Checklist
Breaking*
orNew Feature
labels where relevant.