-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace __jmpb_ssp
with __jmp_mem
#5674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new intrinsic jumps to an absolute address that is fetched from MEM[$hp]. This is more versatile than the __jmpb_ssp that was previously provided. An immediate advantage being that we can have a working version of `ldc` even in debug builds. The test has been modified too, to demonstrate an LDC use that works. A working version is at https://github.com/FuelLabs/ldc-testing/blob/309c79a8f73e26992123fb3ee9777b89dfda9ab1/test-contract/src/main.sw
vaivaswatha
changed the title
Replace __jmpb_ssp with __jmp_mem
Replace Feb 27, 2024
__jmpb_ssp
with __jmp_mem
Benchmark for 45f8b03Click to view benchmark
|
IGI-111
approved these changes
Feb 27, 2024
sdankel
approved these changes
Mar 2, 2024
Benchmark for cfbf986Click to view benchmark
|
Benchmark for 5896535Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new intrinsic jumps to an absolute address that is fetched from
MEM[$hp]
. This is more versatile than the__jmpb_ssp
that was previously provided. An immediate advantage being that we can have a working version ofldc
even in debugbuilds.
The test has been modified too, to demonstrate an LDC use that works. A working version is at https://github.com/FuelLabs/ldc-testing/blob/309c79a8f73e26992123fb3ee9777b89dfda9ab1/test-contract/src/main.sw