Fixes dummy method while using where clause in trait impl. #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using nested generic methods, as in the use case added, the lower method would not be properly replaced and would remain as a trait dummy method. The fix was to do find_method_for_type in the ReplaceDecls of FunctionAplication, this allows the replacement of the function aplication dummy method with a proper method implementation. Fixes #5673
esdrubal
added
bug
Benchmark for c996ad1Click to view benchmark
|
xunilrj
approved these changes
Mar 4, 2024
tritao
approved these changes
Mar 4, 2024
Benchmark for 2c30792Click to view benchmark
|
xunilrj
added a commit
that referenced
this pull request
Mar 20, 2024
## Description This PR contains three fixes: 1 - Fix to partial monomorphization. The fix was just removing a "quick-fix" that was merged and it is not needed anymore after #5684; 2 - To play safe, `compile_fn_call` cache will not be used for autogenerated code; 3 - `experimental-new-encoding` was not being copied in all cases. Two other small changes are: 1 - `Buffer` struct does not offer a generic `push` anymore, because this function was extremely deceiving for primitive datatypes which have memory layouts very different from the encoding memory layout (u16, u32 etc...); 2 - Changing name of one test to make the test more obvious and easier to run just one specific test. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using nested generic methods, as in the use case added, the lower method would not be properly replaced and would remain as a trait dummy method.
The fix was to do find_method_for_type in the ReplaceDecls of FunctionAplication, this allows the replacement of the function application dummy method with a proper method implementation.
Fixes #5673
Checklist
Breaking*orNew Featurelabels where relevant.