Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DebugWithEngines and DeclUniqueId for ParsedDeclId #5718

Merged
merged 7 commits into from Mar 11, 2024
Merged

Implement DebugWithEngines and DeclUniqueId for ParsedDeclId #5718

merged 7 commits into from Mar 11, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Mar 11, 2024

Description

This PR implements DebugWithEngines and DeclUniqueId for ParsedDeclId.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Mar 11, 2024
@tritao tritao requested review from xunilrj, esdrubal, IGI-111 and a team March 11, 2024 09:40
@tritao tritao self-assigned this Mar 11, 2024
@tritao tritao marked this pull request as ready for review March 11, 2024 09:55
@tritao tritao marked this pull request as draft March 11, 2024 10:00
@tritao tritao marked this pull request as ready for review March 11, 2024 12:26
@tritao tritao enabled auto-merge (squash) March 11, 2024 15:44
@tritao tritao merged commit a05ba15 into FuelLabs:master Mar 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esdrubal esdrubal esdrubal approved these changes

@IGI-111 IGI-111 IGI-111 approved these changes

@xunilrj xunilrj Awaiting requested review from xunilrj

Assignees

@tritao tritao

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tritao @esdrubal @IGI-111