Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix predicate entry fn #5723

Merged
merged 9 commits into from Mar 14, 2024
Merged

fix predicate entry fn #5723

merged 9 commits into from Mar 14, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Mar 12, 2024

Description

This PR fix predicate entry function decoding arguments.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Mar 12, 2024
Copy link

Benchmark for d68ded4

Click to view benchmark
Test Base PR %
code_action 5.3±0.16ms 5.3±0.02ms 0.00%
code_lens 288.9±10.75ns 286.7±7.18ns -0.76%
compile 6.2±0.09s 6.1±0.09s -1.61%
completion 4.8±0.03ms 4.8±0.02ms 0.00%
did_change_with_caching 5.6±0.02s 5.6±0.03s 0.00%
document_symbol 953.3±6.67µs 1002.7±61.35µs +5.18%
format 68.6±1.22ms 69.5±1.13ms +1.31%
goto_definition 351.9±6.38µs 361.7±6.56µs +2.78%
highlight 8.8±0.14ms 8.9±0.16ms +1.14%
hover 614.3±11.63µs 595.2±7.08µs -3.11%
idents_at_position 122.8±0.33µs 124.6±1.28µs +1.47%
inlay_hints 701.0±6.84µs 658.2±22.10µs -6.11%
on_enter 486.0±7.00ns 485.5±6.88ns -0.10%
parent_decl_at_position 3.6±0.24ms 3.6±0.03ms 0.00%
prepare_rename 356.7±5.61µs 363.1±6.72µs +1.79%
rename 9.2±0.20ms 9.4±0.04ms +2.17%
semantic_tokens 1016.1±7.03µs 1079.3±38.70µs +6.22%
token_at_position 357.2±2.65µs 361.3±2.90µs +1.15%
tokens_at_position 3.6±0.03ms 3.6±0.07ms 0.00%
tokens_for_file 407.7±2.73µs 408.4±3.38µs +0.17%
traverse 44.5±1.37ms 44.8±1.46ms +0.67%

Copy link

Benchmark for 42c018f

Click to view benchmark
Test Base PR %
code_action 5.4±0.13ms 5.3±0.13ms -1.85%
code_lens 290.0±22.39ns 286.8±6.29ns -1.10%
compile 6.5±0.27s 6.1±0.08s -6.15%
completion 5.2±0.32ms 4.8±0.10ms -7.69%
did_change_with_caching 6.3±0.09s 5.9±0.12s -6.35%
document_symbol 961.8±16.13µs 964.3±16.31µs +0.26%
format 72.0±1.99ms 69.2±3.54ms -3.89%
goto_definition 365.6±18.19µs 359.0±7.99µs -1.81%
highlight 8.9±0.41ms 8.7±0.02ms -2.25%
hover 623.4±61.00µs 588.3±9.74µs -5.63%
idents_at_position 121.2±0.62µs 122.0±1.51µs +0.66%
inlay_hints 660.1±21.24µs 644.3±20.99µs -2.39%
on_enter 492.0±17.81ns 486.3±13.21ns -1.16%
parent_decl_at_position 3.6±0.04ms 3.6±0.03ms 0.00%
prepare_rename 359.5±6.83µs 356.3±5.56µs -0.89%
rename 9.2±0.14ms 9.2±0.08ms 0.00%
semantic_tokens 1059.3±16.93µs 1053.8±15.18µs -0.52%
token_at_position 360.4±2.29µs 361.9±5.09µs +0.42%
tokens_at_position 3.6±0.04ms 3.6±0.07ms 0.00%
tokens_for_file 412.0±6.22µs 413.2±1.70µs +0.29%
traverse 49.1±1.81ms 47.0±1.22ms -4.28%

Copy link

Benchmark for f021b0b

Click to view benchmark
Test Base PR %
code_action 5.2±0.12ms 5.4±0.20ms +3.85%
code_lens 319.7±10.06ns 288.6±10.55ns -9.73%
compile 6.2±0.13s 6.1±0.07s -1.61%
completion 4.8±0.07ms 4.9±0.12ms +2.08%
did_change_with_caching 5.6±0.03s 5.6±0.06s 0.00%
document_symbol 955.2±28.27µs 1016.6±39.57µs +6.43%
format 69.7±1.39ms 69.5±1.79ms -0.29%
goto_definition 358.3±8.99µs 375.1±6.34µs +4.69%
highlight 8.8±0.35ms 8.8±0.03ms 0.00%
hover 595.0±5.21µs 626.5±18.01µs +5.29%
idents_at_position 121.7±0.64µs 122.7±1.54µs +0.82%
inlay_hints 653.8±13.61µs 680.5±22.53µs +4.08%
on_enter 488.9±12.21ns 487.9±17.19ns -0.20%
parent_decl_at_position 3.6±0.04ms 3.6±0.09ms 0.00%
prepare_rename 361.2±5.61µs 370.5±7.71µs +2.57%
rename 9.2±0.19ms 9.2±0.04ms 0.00%
semantic_tokens 1057.3±17.36µs 1067.7±25.56µs +0.98%
token_at_position 351.7±2.07µs 369.7±3.01µs +5.12%
tokens_at_position 3.6±0.02ms 3.6±0.05ms 0.00%
tokens_for_file 412.8±2.69µs 412.1±1.46µs -0.17%
traverse 44.7±1.79ms 44.8±1.80ms +0.22%

Copy link

Benchmark for 586ecb8

Click to view benchmark
Test Base PR %
code_action 5.2±0.03ms 5.3±0.36ms +1.92%
code_lens 294.4±9.83ns 289.4±9.54ns -1.70%
compile 6.1±0.04s 6.1±0.08s 0.00%
completion 4.8±0.14ms 4.8±0.11ms 0.00%
did_change_with_caching 5.6±0.05s 5.6±0.06s 0.00%
document_symbol 1011.7±32.08µs 1049.9±5.66µs +3.78%
format 69.4±1.55ms 69.0±1.41ms -0.58%
goto_definition 359.2±14.46µs 355.3±6.67µs -1.09%
highlight 8.9±0.75ms 8.7±0.21ms -2.25%
hover 598.3±18.05µs 674.3±30.92µs +12.70%
idents_at_position 122.5±0.57µs 123.5±1.58µs +0.82%
inlay_hints 644.0±27.63µs 655.9±26.11µs +1.85%
on_enter 490.1±20.01ns 484.9±12.32ns -1.06%
parent_decl_at_position 3.6±0.04ms 3.6±0.05ms 0.00%
prepare_rename 354.6±8.38µs 360.6±8.09µs +1.69%
rename 9.2±0.29ms 9.2±0.05ms 0.00%
semantic_tokens 1046.7±31.73µs 1058.8±15.08µs +1.16%
token_at_position 351.6±6.90µs 356.0±9.91µs +1.25%
tokens_at_position 3.6±0.18ms 3.6±0.03ms 0.00%
tokens_for_file 408.8±2.27µs 411.2±3.08µs +0.59%
traverse 45.5±2.20ms 44.9±1.43ms -1.32%

@xunilrj xunilrj requested review from danielbate, hal3e and a team March 13, 2024 10:41
@xunilrj xunilrj mentioned this pull request Mar 13, 2024
22 tasks
IGI-111
IGI-111 previously approved these changes Mar 13, 2024
@IGI-111 IGI-111 requested a review from a team March 13, 2024 13:47
@IGI-111 IGI-111 requested a review from a team March 13, 2024 14:33
Copy link

Benchmark for 4fe0003

Click to view benchmark
Test Base PR %
code_action 5.3±0.10ms 5.3±0.17ms 0.00%
code_lens 294.7±7.89ns 286.3±7.35ns -2.85%
compile 6.2±0.08s 6.2±0.10s 0.00%
completion 4.8±0.09ms 4.8±0.08ms 0.00%
did_change_with_caching 6.0±0.14s 5.7±0.08s -5.00%
document_symbol 1037.4±67.43µs 1003.8±46.33µs -3.24%
format 70.0±2.46ms 70.2±1.40ms +0.29%
goto_definition 360.5±13.72µs 364.1±7.54µs +1.00%
highlight 8.8±0.27ms 8.8±0.27ms 0.00%
hover 593.3±5.84µs 659.4±21.65µs +11.14%
idents_at_position 122.1±0.99µs 123.9±2.08µs +1.47%
inlay_hints 647.6±27.38µs 661.7±13.00µs +2.18%
on_enter 487.2±12.37ns 482.9±13.73ns -0.88%
parent_decl_at_position 3.6±0.05ms 3.6±0.12ms 0.00%
prepare_rename 361.8±3.56µs 365.0±5.77µs +0.88%
rename 9.2±0.15ms 9.3±0.27ms +1.09%
semantic_tokens 1016.7±21.37µs 1064.7±19.48µs +4.72%
token_at_position 353.8±2.11µs 357.2±2.54µs +0.96%
tokens_at_position 3.6±0.02ms 3.6±0.06ms 0.00%
tokens_for_file 410.1±7.59µs 432.1±5.92µs +5.36%
traverse 48.1±2.69ms 44.9±1.57ms -6.65%

@JoshuaBatty JoshuaBatty merged commit a81e481 into master Mar 14, 2024
35 checks passed
@JoshuaBatty JoshuaBatty deleted the xunilrj/fix-predicate-entry branch March 14, 2024 01:12
@hal3e hal3e restored the xunilrj/fix-predicate-entry branch March 14, 2024 08:33
@hal3e hal3e deleted the xunilrj/fix-predicate-entry branch March 20, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants