Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add u256 conversions #5767

Merged
merged 15 commits into from Apr 2, 2024
Merged

Add u256 conversions #5767

merged 15 commits into from Apr 2, 2024

Conversation

SwayStar123
Copy link
Member

@SwayStar123 SwayStar123 commented Mar 25, 2024

Description

Adds conversion methods from u8, u16, u32, u64, b256 to u256, and u256 to b256

Closes #4800

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 enabled auto-merge (squash) March 25, 2024 09:46
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you need tests.

@K1-R1 K1-R1 self-requested a review March 28, 2024 16:07
Copy link
Contributor

@K1-R1 K1-R1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IGI-111 IGI-111 enabled auto-merge (squash) April 2, 2024 06:58
@IGI-111 IGI-111 merged commit 905bb49 into master Apr 2, 2024
34 of 67 checks passed
@IGI-111 IGI-111 deleted the u256conversions branch April 2, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impl From<b256> for U256
3 participants